conf: clean up memory containing secrets before freeing

The password may not be valid in the error branch, but for
higher security, it's better to clean up the memory before
freeing it.

Signed-off-by: jiangjiacheng <jiangjiacheng@huawei.com>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
This commit is contained in:
jiangjiacheng 2022-09-06 21:48:29 +08:00 committed by Michal Privoznik
parent 2ce45ddea3
commit 51f8130d78

View File

@ -60,6 +60,7 @@
#include "virdomainsnapshotobjlist.h"
#include "virdomaincheckpointobjlist.h"
#include "virutil.h"
#include "virsecureerase.h"
#define VIR_FROM_THIS VIR_FROM_DOMAIN
@ -10849,6 +10850,7 @@ virDomainGraphicsAuthDefParseXML(xmlNodePtr node,
virReportError(VIR_ERR_INTERNAL_ERROR,
_("cannot parse password validity time '%s', expect YYYY-MM-DDTHH:MM:SS"),
validTo);
virSecureEraseString(def->passwd);
VIR_FREE(def->passwd);
return -1;
}