External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 03:12:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuBuildControllersByTypeCommandLine: use VIR_AUTOFREE

Browse Source 
Reduce the scope of the variable to get it freed for every controller
processed.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Ján Tomko 2019-08-20 13:21:28 +02:00
parent f4bc171676
commit 5253def175
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_command.c
View File

@ -3191,12 +3191,12 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr cmd,
virQEMUCapsPtr qemuCaps,
virDomainControllerType type)
{
char *devstr = NULL;
int ret = -1;
size_t i;
for (i = 0; i < def->ncontrollers; i++) {
virDomainControllerDefPtr cont = def->controllers[i];
VIR_AUTOFREE(char *) devstr = NULL;
if (cont->type != type)
continue;
@ -3229,7 +3229,6 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr cmd,
continue;
}
VIR_FREE(devstr);
if (qemuBuildControllerDevStr(def, cont, qemuCaps, &devstr) < 0)
goto cleanup;
@ -3244,7 +3243,6 @@ qemuBuildControllersByTypeCommandLine(virCommandPtr cmd,
ret = 0;
cleanup:
VIR_FREE(devstr);
return ret;
}