From 528191c754128a2831904cddcbcfb6860bf3a338 Mon Sep 17 00:00:00 2001
From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 3 Dec 2019 17:36:35 +0100
Subject: [PATCH] conf: domaincaps: Add 'backup' feature flag
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This flag will allow figuring out whether the hypervisor supports the
incremental backup and checkpoint features.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 docs/formatdomaincaps.html.in  | 8 ++++++++
 docs/schemas/domaincaps.rng    | 9 +++++++++
 src/conf/domain_capabilities.c | 1 +
 src/conf/domain_capabilities.h | 1 +
 4 files changed, 19 insertions(+)

diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
index 0bafb67705..6bf7a1c17a 100644
--- a/docs/formatdomaincaps.html.in
+++ b/docs/formatdomaincaps.html.in
@@ -517,6 +517,7 @@
     &lt;vmcoreinfo supported='yes'/&gt;
     &lt;genid supported='yes'/&gt;
     &lt;backingStoreInput supported='yes'/&gt;
+    &lt;backup supported='yes'/&gt;
     &lt;sev&gt;
       &lt;cbitpos&gt;47&lt;/cbitpos&gt;
       &lt;reduced-phys-bits&gt;1&lt;/reduced-phys-bits&gt;
@@ -560,6 +561,13 @@
     the disk to a running guest, or similar.
     </p>
 
+    <h4><a id="featureBackup">backup</a></h4>
+
+    <p>Reports whether the hypervisor supports the backup, checkpoint, and
+    related features. (<code>virDomainBackupBegin</code>,
+    <code>virDomainCheckpointCreateXML</code> etc).
+    </p>
+
     <h4><a id="elementsSEV">SEV capabilities</a></h4>
 
     <p>AMD Secure Encrypted Virtualization (SEV) capabilities are exposed under
diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng
index 88b545ec2a..682cc82177 100644
--- a/docs/schemas/domaincaps.rng
+++ b/docs/schemas/domaincaps.rng
@@ -210,6 +210,9 @@
       <optional>
         <ref name='backingStoreInput'/>
       </optional>
+      <optional>
+        <ref name='backup'/>
+      </optional>
       <optional>
         <ref name='sev'/>
       </optional>
@@ -241,6 +244,12 @@
     </element>
   </define>
 
+  <define name='backup'>
+    <element name='backup'>
+      <ref name='supported'/>
+    </element>
+  </define>
+
   <define name='sev'>
     <element name='sev'>
       <ref name='supported'/>
diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index ca208f2340..921d795630 100644
--- a/src/conf/domain_capabilities.c
+++ b/src/conf/domain_capabilities.c
@@ -41,6 +41,7 @@ VIR_ENUM_IMPL(virDomainCapsFeature,
               "vmcoreinfo",
               "genid",
               "backingStoreInput",
+              "backup",
 );
 
 static virClassPtr virDomainCapsClass;
diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h
index 4ec9fe006c..9f4a23d015 100644
--- a/src/conf/domain_capabilities.h
+++ b/src/conf/domain_capabilities.h
@@ -163,6 +163,7 @@ typedef enum {
     VIR_DOMAIN_CAPS_FEATURE_VMCOREINFO,
     VIR_DOMAIN_CAPS_FEATURE_GENID,
     VIR_DOMAIN_CAPS_FEATURE_BACKING_STORE_INPUT,
+    VIR_DOMAIN_CAPS_FEATURE_BACKUP,
 
     VIR_DOMAIN_CAPS_FEATURE_LAST
 } virDomainCapsFeature;