mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 06:05:27 +00:00
conf: Ignore emulatorpin if vcpu placement is auto
When vcpu placement is "auto", the domain process will be pinned to advisory nodeset from querying numad, While emulatorpin will override the pinning. That means both of them are to set the pinning policy for domain process, but conflicts with each other. This patch ingore emulatorpin if vcpu placement is "auto", because <vcpu> placement can't be simply ignored for <numatune> placement could default to it.
This commit is contained in:
parent
0df1a79089
commit
5378effd57
@ -8880,7 +8880,12 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
|
||||
goto error;
|
||||
}
|
||||
|
||||
/* Ignore emulatorpin if <vcpu> placement is "auto", they
|
||||
* conflicts with each other, and <vcpu> placement can't be
|
||||
* simply ignored, as <numatune>'s placement defaults to it.
|
||||
*/
|
||||
if (n) {
|
||||
if (def->placement_mode != VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO) {
|
||||
if (n > 1) {
|
||||
virReportError(VIR_ERR_XML_ERROR, "%s",
|
||||
_("only one emulatorpin is supported"));
|
||||
@ -8893,6 +8898,9 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
|
||||
|
||||
if (!def->cputune.emulatorpin)
|
||||
goto error;
|
||||
} else {
|
||||
VIR_WARN("Ignore emulatorpin for <vcpu> placement is 'auto'");
|
||||
}
|
||||
}
|
||||
VIR_FREE(nodes);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user