mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-27 19:11:16 +00:00
virCryptoEncryptDataAESgnutls: Don't secure erase gnutls_datum_t structs
'gnutls_datum_t' simply holds pointers to the encryption key and its length. There's absolutely no point in securely erasing that. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
ac3614b5ad
commit
53e46e4cd6
@ -164,8 +164,6 @@ virCryptoEncryptDataAESgnutls(gnutls_cipher_algorithm_t gnutls_enc_alg,
|
|||||||
/* Encrypt the data and free the memory for cipher operations */
|
/* Encrypt the data and free the memory for cipher operations */
|
||||||
rc = gnutls_cipher_encrypt(handle, ciphertext, ciphertextlen);
|
rc = gnutls_cipher_encrypt(handle, ciphertext, ciphertextlen);
|
||||||
gnutls_cipher_deinit(handle);
|
gnutls_cipher_deinit(handle);
|
||||||
virSecureErase(&enc_key, sizeof(gnutls_datum_t));
|
|
||||||
virSecureErase(&iv_buf, sizeof(gnutls_datum_t));
|
|
||||||
if (rc < 0) {
|
if (rc < 0) {
|
||||||
virReportError(VIR_ERR_INTERNAL_ERROR,
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
||||||
_("failed to encrypt the data: '%s'"),
|
_("failed to encrypt the data: '%s'"),
|
||||||
@ -180,8 +178,6 @@ virCryptoEncryptDataAESgnutls(gnutls_cipher_algorithm_t gnutls_enc_alg,
|
|||||||
error:
|
error:
|
||||||
virSecureErase(ciphertext, ciphertextlen);
|
virSecureErase(ciphertext, ciphertextlen);
|
||||||
g_free(ciphertext);
|
g_free(ciphertext);
|
||||||
virSecureErase(&enc_key, sizeof(gnutls_datum_t));
|
|
||||||
virSecureErase(&iv_buf, sizeof(gnutls_datum_t));
|
|
||||||
return -1;
|
return -1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user