External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

util: Remove NONNULL's for virNetDevVPortProfile[Associate|Disassociate]

Browse Source 
The source code will check for NULL arguments for 'macvtap_macaddr' and
'vmuuid', so no need for the NONNULL in the prototypes. Following the stack
for both arguments to virNetDevVPortProfileOpSetLink also shows called
functions would handle a NULL value.

Additionally, modified the prototype to use the same 'macvtap_macaddr'
name as the source code for consistency.
This commit is contained in:
John Ferlan 2017-03-22 07:58:05 -04:00
parent fbd804ff3d
commit 5482db8176
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/util/virnetdevvportprofile.h
View File

@ -95,23 +95,21 @@ int virNetDevVPortProfileMerge3(virNetDevVPortProfilePtr *result,
int virNetDevVPortProfileAssociate(const char *ifname, int virNetDevVPortProfileAssociate(const char *ifname,
const virNetDevVPortProfile *virtPort, const virNetDevVPortProfile *virtPort,
const virMacAddr *macaddr, const virMacAddr *macvtap_macaddr,
const char *linkdev, const char *linkdev,
int vf, int vf,
const unsigned char *vmuuid, const unsigned char *vmuuid,
virNetDevVPortProfileOp vmOp, virNetDevVPortProfileOp vmOp,
bool setlink_only) bool setlink_only)
ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(6) ATTRIBUTE_NONNULL(4) ATTRIBUTE_RETURN_CHECK;
ATTRIBUTE_RETURN_CHECK;
int virNetDevVPortProfileDisassociate(const char *ifname, int virNetDevVPortProfileDisassociate(const char *ifname,
const virNetDevVPortProfile *virtPort, const virNetDevVPortProfile *virtPort,
const virMacAddr *macaddr, const virMacAddr *macvtap_macaddr,
const char *linkdev, const char *linkdev,
int vf, int vf,
virNetDevVPortProfileOp vmOp) virNetDevVPortProfileOp vmOp)
ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(4) ATTRIBUTE_RETURN_CHECK;
ATTRIBUTE_RETURN_CHECK;
#endif /* __VIR_NETDEV_VPORT_PROFILE_H__ */ #endif /* __VIR_NETDEV_VPORT_PROFILE_H__ */