External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: allow retrieving ethtool features when unprivileged

Browse Source 
The only reason that the ethtool features weren't being retrieved in
an unprivileged libvirtd was because they required ioctl(), and the
ioctl was using an AF_PACKET socket, which requires root. Now that we
are using AF_UNIX for ioctl(), this restriction can be removed.
This commit is contained in:
Laine Stump 2017-03-17 17:49:45 -04:00
parent 1c9a8746ef
commit 549fe5a882
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/virnetdev.c
View File

@ -2583,12 +2583,6 @@ virNetDevGetFeatures(const char *ifname,
if (!(*out = virBitmapNew(VIR_NET_DEV_FEAT_LAST)))
return -1;
/* Only fetch features if we're privileged, but no need to fail */
if (geteuid() != 0) {
VIR_DEBUG("ETHTOOL feature bits not available in session mode");
return 0;
}
if ((fd = virNetDevSetupControl(ifname, &ifr)) < 0)
goto cleanup;