External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-24 13:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix leak of objects when reconnecting to QEMU instances

Browse Source 
The 'error' cleanup block in qemuProcessReconnect() had a
'return' statement in the middle of it. This caused a leak
of virConnectPtr & virQEMUDriverConfigPtr instances. This
was identified because netcf recently started checking its
refcount in libvirtd shutdown:

netcfStateCleanup:109 : internal error: Attempt to close netcf state driver with open connections

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-10-29 13:58:00 +00:00
parent b260a77e34
commit 54a2411220
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/qemu/qemu_process.c
View File

@ -3219,10 +3219,7 @@ error:
if (!virDomainObjIsActive(obj)) { if (!virDomainObjIsActive(obj)) {
if (virObjectUnref(obj)) if (virObjectUnref(obj))
virObjectUnlock(obj); virObjectUnlock(obj);
return; } else if (virObjectUnref(obj)) {
}
if (virObjectUnref(obj)) {
/* We can't get the monitor back, so must kill the VM /* We can't get the monitor back, so must kill the VM
* to remove danger of it ending up running twice if * to remove danger of it ending up running twice if
* user tries to start it again later * user tries to start it again later