External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-04-01 20:05:19 +00:00
Code

Plug test-related leaks.

Browse Source 
* src/test.c (testLoadNetwork): Free forwardDev.
(testLoadDomain): Free ctxt.
(testLoadNetwork): Likewise.
(testOpenFromFile): Likewise.
This commit is contained in:
Jim Meyering 2008-01-30 19:50:14 +00:00
parent 17ef6faa7f
commit 5561e9125f
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
Wed Jan 30 20:49:34 CET 2008 Jim Meyering <meyering@redhat.com>
Plug test-related leaks.
* src/test.c (testLoadNetwork): Free forwardDev.
(testLoadDomain): Free ctxt.
(testLoadNetwork): Likewise.
(testOpenFromFile): Likewise.
Wed Jan 30 13:18:25 EST 2008 Daniel P. Berrange <berrange@redhat.com>
* src/hash.c: Remove double mutex lock() flaw

8
src/test.c
View File

@ -351,9 +351,11 @@ static int testLoadDomain(virConnectPtr conn,
privconn->domains[handle].onPoweroff = onPoweroff;
privconn->domains[handle].onCrash = onCrash;
xmlXPathFreeContext(ctxt);
return (handle);
error:
xmlXPathFreeContext(ctxt);
free(name);
return (-1);
}
@ -507,6 +509,7 @@ static int testLoadNetwork(virConnectPtr conn,
if (forwardDev) {
strncpy(privconn->networks[handle].forwardDev, forwardDev, sizeof(privconn->networks[handle].forwardDev)-1);
privconn->networks[handle].forwardDev[sizeof(privconn->networks[handle].forwardDev)-1] = '\0';
free(forwardDev);
}
strncpy(privconn->networks[handle].ipAddress, ipaddress, sizeof(privconn->networks[handle].ipAddress)-1);
@ -521,9 +524,12 @@ static int testLoadNetwork(virConnectPtr conn,
strncpy(privconn->networks[handle].dhcpEnd, dhcpend, sizeof(privconn->networks[handle].dhcpEnd)-1);
privconn->networks[handle].dhcpEnd[sizeof(privconn->networks[handle].dhcpEnd)-1] = '\0';
free(dhcpend);
xmlXPathFreeContext(ctxt);
return (handle);
error:
xmlXPathFreeContext(ctxt);
free (forwardDev);
free(ipaddress);
free(ipnetmask);
free(dhcpstart);
@ -827,11 +833,13 @@ static int testOpenFromFile(virConnectPtr conn,
}
}
xmlXPathFreeContext(ctxt);
xmlFreeDoc(xml);
return (0);
error:
xmlXPathFreeContext(ctxt);
free(domains);
free(networks);
if (xml)