External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-03 04:45:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make it easier to debug tests running programs

Browse Source 
* tests/testutils.c: Don't discard stderr when running
	external programs during tests
This commit is contained in:
Daniel P. Berrange 2009-07-06 15:03:31 +01:00
parent ad6d5acb42
commit 561e60732f
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/testutils.c
View File

@ -156,7 +156,6 @@ void virtTestCaptureProgramExecChild(const char *const argv[],
int i;
int open_max;
int stdinfd = -1;
int stderrfd = -1;
const char *const env[] = {
"LANG=C",
#if WITH_DRIVER_MODULES
@ -167,13 +166,10 @@ void virtTestCaptureProgramExecChild(const char *const argv[],
if ((stdinfd = open("/dev/null", O_RDONLY)) < 0)
goto cleanup;
if ((stderrfd = open("/dev/null", O_WRONLY)) < 0)
goto cleanup;
open_max = sysconf (_SC_OPEN_MAX);
for (i = 0; i < open_max; i++) {
if (i != stdinfd &&
i != stderrfd &&
i != pipefd)
close(i);
}
@ -182,7 +178,7 @@ void virtTestCaptureProgramExecChild(const char *const argv[],
goto cleanup;
if (dup2(pipefd, STDOUT_FILENO) != STDOUT_FILENO)
goto cleanup;
if (dup2(stderrfd, STDERR_FILENO) != STDERR_FILENO)
if (dup2(pipefd, STDERR_FILENO) != STDERR_FILENO)
goto cleanup;
/* SUS is crazy here, hence the cast */
@ -191,8 +187,6 @@ void virtTestCaptureProgramExecChild(const char *const argv[],
cleanup:
if (stdinfd != -1)
close(stdinfd);
if (stderrfd != -1)
close(stderrfd);
}
int virtTestCaptureProgramOutput(const char *const argv[],