External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-08-26 18:41:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tue Feb 20 19:08:58 IST 2007 Mark McLoughlin <markmc@redhat.com>

Browse Source 
* qemud/conf.c: use strerror(errno) in some error messages
        to make them a bit more useful
This commit is contained in:
Mark McLoughlin 2007-02-20 19:09:44 +00:00
parent 4579467783
commit 5687da2c7a
2 changed files with 28 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ChangeLog
View File

@ -1,13 +1,18 @@
Fri Feb 20 19:07:12 IST 2007 Mark McLoughlin <markmc@redhat.com> Tue Feb 20 19:08:58 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/conf.c: use strerror(errno) in some error messages
to make them a bit more useful
Tue Feb 20 19:07:12 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/conf.c: don't free active networks/vms if we * qemud/conf.c: don't free active networks/vms if we
fail to save the new config fail to save the new config
Fri Feb 20 18:25:42 IST 2007 Mark McLoughlin <markmc@redhat.com> Tue Feb 20 18:25:42 IST 2007 Mark McLoughlin <markmc@redhat.com>
* virsh.c: cmdNetworkList() re-indent this. * virsh.c: cmdNetworkList() re-indent this.
Fri Feb 20 17:49:22 IST 2007 Mark McLoughlin <markmc@redhat.com> Tue Feb 20 17:49:22 IST 2007 Mark McLoughlin <markmc@redhat.com>
Fix a few leaks Fix a few leaks
@ -18,28 +23,28 @@ Fri Feb 20 17:49:22 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/iptables.c: fix a typo causing a leak * qemud/iptables.c: fix a typo causing a leak
Fri Feb 20 16:49:53 IST 2007 Mark McLoughlin <markmc@redhat.com> Tue Feb 20 16:49:53 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/conf.c, qemud/qemud.c: only create config dirs * qemud/conf.c, qemud/qemud.c: only create config dirs
when actually trying to write out config. when actually trying to write out config.
Fri Feb 20 09:56:35 IST 2007 Mark McLoughlin <markmc@redhat.com> Tue Feb 20 09:56:35 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/bridge.c: change the fix for the alignment warning * qemud/bridge.c: change the fix for the alignment warning
a little. a little.
Fri Feb 20 09:03:05 IST 2007 Mark McLoughlin <markmc@redhat.com> Tue Feb 20 09:03:05 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/qemud.c: clean up qemudInitialize() and qemudListen() * qemud/qemud.c: clean up qemudInitialize() and qemudListen()
so as to coalesce the two "system vs. user" code paths and so as to coalesce the two "system vs. user" code paths and
fix up some problems noticed by dan. fix up some problems noticed by dan.
Fri Feb 19 16:59:18 IST 2007 Mark McLoughlin <markmc@redhat.com> Mon Feb 19 16:59:18 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/qemud.c: don't shutdown guest and networks on * qemud/qemud.c: don't shutdown guest and networks on
SIGHUP SIGHUP
Fri Feb 19 16:58:53 IST 2007 Mark McLoughlin <markmc@redhat.com> Mon Feb 19 16:58:53 IST 2007 Mark McLoughlin <markmc@redhat.com>
* qemud/qemud.c: handle SIGQUIT. * qemud/qemud.c: handle SIGQUIT.

24
qemud/conf.c
View File

@ -1158,23 +1158,23 @@ static int qemudSaveConfig(struct qemud_server *server,
O_WRONLY | O_CREAT | O_TRUNC, O_WRONLY | O_CREAT | O_TRUNC,
S_IRUSR | S_IWUSR )) < 0) { S_IRUSR | S_IWUSR )) < 0) {
qemudReportError(server, VIR_ERR_INTERNAL_ERROR, qemudReportError(server, VIR_ERR_INTERNAL_ERROR,
"cannot create config file %s", "cannot create config file %s: %s",
vm->configFile); vm->configFile, strerror(errno));
goto cleanup; goto cleanup;
} }
towrite = strlen(xml); towrite = strlen(xml);
if (write(fd, xml, towrite) != towrite) { if (write(fd, xml, towrite) != towrite) {
qemudReportError(server, VIR_ERR_INTERNAL_ERROR, qemudReportError(server, VIR_ERR_INTERNAL_ERROR,
"cannot write config file %s", "cannot write config file %s: %s",
vm->configFile); vm->configFile, strerror(errno));
goto cleanup; goto cleanup;
} }
if (close(fd) < 0) { if (close(fd) < 0) {
qemudReportError(server, VIR_ERR_INTERNAL_ERROR, qemudReportError(server, VIR_ERR_INTERNAL_ERROR,
"cannot save config file %s", "cannot save config file %s: %s",
vm->configFile); vm->configFile, strerror(errno));
goto cleanup; goto cleanup;
} }
@ -1293,18 +1293,24 @@ static int qemudSaveNetworkConfig(struct qemud_server *server,
if ((fd = open(network->configFile, if ((fd = open(network->configFile,
O_WRONLY | O_CREAT | O_TRUNC, O_WRONLY | O_CREAT | O_TRUNC,
S_IRUSR | S_IWUSR )) < 0) { S_IRUSR | S_IWUSR )) < 0) {
qemudReportError(server, VIR_ERR_INTERNAL_ERROR, "cannot create config file %s", network->configFile); qemudReportError(server, VIR_ERR_INTERNAL_ERROR,
"cannot create config file %s: %s",
network->configFile, strerror(errno));
goto cleanup; goto cleanup;
} }
towrite = strlen(xml); towrite = strlen(xml);
if (write(fd, xml, towrite) != towrite) { if (write(fd, xml, towrite) != towrite) {
qemudReportError(server, VIR_ERR_INTERNAL_ERROR, "cannot write config file %s", network->configFile); qemudReportError(server, VIR_ERR_INTERNAL_ERROR,
"cannot write config file %s",
network->configFile, strerror(errno));
goto cleanup; goto cleanup;
} }
if (close(fd) < 0) { if (close(fd) < 0) {
qemudReportError(server, VIR_ERR_INTERNAL_ERROR, "cannot save config file %s", network->configFile); qemudReportError(server, VIR_ERR_INTERNAL_ERROR,
"cannot save config file %s",
network->configFile, strerror(errno));
goto cleanup; goto cleanup;
} }