External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-24 14:45:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: domain: Convert virDomainDiskDef's 'rawio' to virTristateBool

Browse Source 
Use the appropriate type for the variable and refactor the XML parser to
parse it correctly using virXMLPropEnum.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-04-16 10:46:00 +02:00
parent 35efc9b535
commit 56a190068d
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/conf/domain_conf.c
View File

@ -9314,7 +9314,6 @@ virDomainDiskDefParseXML(virDomainXMLOption *xmlopt,
bool source = false; bool source = false;
g_autofree char *tmp = NULL; g_autofree char *tmp = NULL;
g_autofree char *snapshot = NULL; g_autofree char *snapshot = NULL;
g_autofree char *rawio = NULL;
g_autofree char *sgio = NULL; g_autofree char *sgio = NULL;
g_autofree char *target = NULL; g_autofree char *target = NULL;
g_autofree char *bus = NULL; g_autofree char *bus = NULL;
@ -9357,7 +9356,9 @@ virDomainDiskDefParseXML(virDomainXMLOption *xmlopt,
snapshot = virXMLPropString(node, "snapshot"); snapshot = virXMLPropString(node, "snapshot");
rawio = virXMLPropString(node, "rawio"); if (virXMLPropTristateBool(node, "rawio", VIR_XML_PROP_OPTIONAL, &def->rawio) < 0)
return NULL;
sgio = virXMLPropString(node, "sgio"); sgio = virXMLPropString(node, "sgio");
for (cur = node->children; cur != NULL; cur = cur->next) { for (cur = node->children; cur != NULL; cur = cur->next) {
@ -9473,15 +9474,6 @@ virDomainDiskDefParseXML(virDomainXMLOption *xmlopt,
} }
} }
if (rawio) {
if ((def->rawio = virTristateBoolTypeFromString(rawio)) <= 0) {
virReportError(VIR_ERR_XML_ERROR,
_("unknown disk rawio setting '%s'"),
rawio);
return NULL;
}
}
if (sgio) { if (sgio) {
if ((def->sgio = virDomainDeviceSGIOTypeFromString(sgio)) <= 0) { if ((def->sgio = virDomainDeviceSGIOTypeFromString(sgio)) <= 0) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,

2
src/conf/domain_conf.h
View File

@ -577,7 +577,7 @@ struct _virDomainDiskDef {
virDomainStartupPolicy startupPolicy; virDomainStartupPolicy startupPolicy;
bool transient; bool transient;
virDomainDeviceInfo info; virDomainDeviceInfo info;
int rawio; /* enum virTristateBool */ virTristateBool rawio;
int sgio; /* enum virDomainDeviceSGIO */ int sgio; /* enum virDomainDeviceSGIO */
int discard; /* enum virDomainDiskDiscard */ int discard; /* enum virDomainDiskDiscard */
unsigned int iothread; /* unused = 0, > 0 specific thread # */ unsigned int iothread; /* unused = 0, > 0 specific thread # */