External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 01:45:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: cpu-stats: Extract common printing code into a function

Browse Source 
Simplify the code by extracting a common code path.
This commit is contained in:
Peter Krempa 2015-12-07 09:21:08 +01:00
parent 51f07d8f0f
commit 57177f1abd
1 changed files with 24 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
tools/virsh-domain.c
View File

@ -7237,12 +7237,31 @@ static const vshCmdOptDef opts_cpu_stats[] = {
{.name = NULL} {.name = NULL}
}; };
static void
vshCPUStatsPrintField(vshControl *ctl,
virTypedParameterPtr param)
{
vshPrint(ctl, "\t%-12s ", param->field);
if ((STREQ(param->field, VIR_DOMAIN_CPU_STATS_CPUTIME) ||
STREQ(param->field, VIR_DOMAIN_CPU_STATS_USERTIME) ||
STREQ(param->field, VIR_DOMAIN_CPU_STATS_SYSTEMTIME)) &&
param->type == VIR_TYPED_PARAM_ULLONG) {
vshPrint(ctl, "%9lld.%09lld seconds\n",
param->value.ul / 1000000000,
param->value.ul % 1000000000);
} else {
char *s = vshGetTypedParamValue(ctl, param);
vshPrint(ctl, "%s\n", s);
VIR_FREE(s);
}
}
static bool static bool
cmdCPUStats(vshControl *ctl, const vshCmd *cmd) cmdCPUStats(vshControl *ctl, const vshCmd *cmd)
{ {
virDomainPtr dom; virDomainPtr dom;
virTypedParameterPtr params = NULL; virTypedParameterPtr params = NULL;
int pos, max_id, cpu = 0, show_count = -1, nparams = 0, stats_per_cpu; int max_id, cpu = 0, show_count = -1, nparams = 0, stats_per_cpu;
size_t i, j; size_t i, j;
bool show_total = false, show_per_cpu = false; bool show_total = false, show_per_cpu = false;
unsigned int flags = 0; unsigned int flags = 0;
@ -7317,21 +7336,8 @@ cmdCPUStats(vshControl *ctl, const vshCmd *cmd)
continue; continue;
vshPrint(ctl, "CPU%zu:\n", cpu + i); vshPrint(ctl, "CPU%zu:\n", cpu + i);
for (j = 0; j < nparams; j++) { for (j = 0; j < nparams; j++)
pos = i * nparams + j; vshCPUStatsPrintField(ctl, params + (i * nparams + j));
vshPrint(ctl, "\t%-12s ", params[pos].field);
if ((STREQ(params[pos].field, VIR_DOMAIN_CPU_STATS_CPUTIME) ||
STREQ(params[pos].field, VIR_DOMAIN_CPU_STATS_VCPUTIME)) &&
params[j].type == VIR_TYPED_PARAM_ULLONG) {
vshPrint(ctl, "%9lld.%09lld seconds\n",
params[pos].value.ul / 1000000000,
params[pos].value.ul % 1000000000);
} else {
char *s = vshGetTypedParamValue(ctl, &params[pos]);
vshPrint(ctl, _("%s\n"), s);
VIR_FREE(s);
}
}
} }
cpu += ncpus; cpu += ncpus;
show_count -= ncpus; show_count -= ncpus;
@ -7363,21 +7369,8 @@ cmdCPUStats(vshControl *ctl, const vshCmd *cmd)
goto failed_stats; goto failed_stats;
vshPrint(ctl, _("Total:\n")); vshPrint(ctl, _("Total:\n"));
for (i = 0; i < stats_per_cpu; i++) { for (i = 0; i < stats_per_cpu; i++)
vshPrint(ctl, "\t%-12s ", params[i].field); vshCPUStatsPrintField(ctl, params + i);
if ((STREQ(params[i].field, VIR_DOMAIN_CPU_STATS_CPUTIME) ||
STREQ(params[i].field, VIR_DOMAIN_CPU_STATS_USERTIME) ||
STREQ(params[i].field, VIR_DOMAIN_CPU_STATS_SYSTEMTIME)) &&
params[i].type == VIR_TYPED_PARAM_ULLONG) {
vshPrint(ctl, "%9lld.%09lld seconds\n",
params[i].value.ul / 1000000000,
params[i].value.ul % 1000000000);
} else {
char *s = vshGetTypedParamValue(ctl, &params[i]);
vshPrint(ctl, "%s\n", s);
VIR_FREE(s);
}
}
ret = true; ret = true;