mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-02-22 03:12:22 +00:00
util: Make virFileClose() quiet on success
While it's certainly good to log events like "failed to close fd" and "tried to close invalid fd", which are likely to be the consequence of some bug in libvirt, logging a message every single time a file descriptor is closed successfully is perhaps excessive and can lead to useful information being missed among the noise. Log filters don't help in this situation, because filtering out all of util.file is too big a hammer and would cause important messages to be left out as well. To give an idea of just how much noise this single debug statement can cause, here's a real life example from a quite large libvirtd log I had to look at recently: $ grep virFile libvirt.log | wc -l 1307 $ grep virFile libvirt.log | grep -v 'Closed fd' | wc -l 343 Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
parent
7754933983
commit
57515a4c36
@ -131,8 +131,6 @@ int virFileClose(int *fdptr, virFileCloseFlags flags)
|
||||
VIR_DEBUG("Failed to close fd %d: %s",
|
||||
*fdptr, g_strerror(errno));
|
||||
}
|
||||
} else {
|
||||
VIR_DEBUG("Closed fd %d", *fdptr);
|
||||
}
|
||||
}
|
||||
*fdptr = -1;
|
||||
|
Loading…
x
Reference in New Issue
Block a user