From 576e0ce64aacbc8db310646ec0e08c4e68051673 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Mon, 5 Oct 2020 19:09:12 +0200 Subject: [PATCH] util: firewall: use g_new0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Ján Tomko Reviewed-by: Erik Skultety --- src/util/virfirewall.c | 9 +++------ src/util/virfirewalld.c | 6 ++---- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 22e717bce4..f6a8beec95 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -211,8 +211,7 @@ virFirewallGroupNew(void) { virFirewallGroupPtr group; - if (VIR_ALLOC(group) < 0) - return NULL; + group = g_new0(virFirewallGroup, 1); return group; } @@ -235,8 +234,7 @@ virFirewallPtr virFirewallNew(void) if (virFirewallInitialize() < 0) return NULL; - if (VIR_ALLOC(firewall) < 0) - return NULL; + firewall = g_new0(virFirewall, 1); return firewall; } @@ -346,8 +344,7 @@ virFirewallAddRuleFullV(virFirewallPtr firewall, group = firewall->groups[firewall->currentGroup]; - if (VIR_ALLOC(rule) < 0) - goto no_memory; + rule = g_new0(virFirewallRule, 1); rule->layer = layer; rule->queryCB = cb; diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index a94ac7c183..3178bf4b3d 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -139,8 +139,7 @@ virFirewallDGetBackend(void) if (!sysbus) return -1; - if (VIR_ALLOC(error) < 0) - return -1; + error = g_new0(virError, 1); message = g_variant_new("(ss)", "org.fedoraproject.FirewallD1.config", @@ -289,8 +288,7 @@ virFirewallDApplyRule(virFirewallLayer layer, return -1; } - if (VIR_ALLOC(error) < 0) - return -1; + error = g_new0(virError, 1); message = g_variant_new("(s@as)", ipv,