mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-11 12:25:52 +00:00
storage: fix unlikely memory leak in rbd backend
virStorageBackendRBDRefreshPool() first allocates an array big enough to hold 1024 names, then calls rbd_list(), which returns ERANGE if the array isn't big enough. When that happens, the VIR_ALLOC_N is called again with a larger size. Unfortunately, the original array isn't freed before allocating a new one.
This commit is contained in:
parent
5ab0c045e3
commit
57f39e03ff
@ -317,6 +317,7 @@ static int virStorageBackendRBDRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED,
|
|||||||
VIR_WARN("%s", _("A problem occurred while listing RBD images"));
|
VIR_WARN("%s", _("A problem occurred while listing RBD images"));
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
|
VIR_FREE(names);
|
||||||
}
|
}
|
||||||
|
|
||||||
for (i = 0, name = names; name < names + max_size; i++) {
|
for (i = 0, name = names; name < names + max_size; i++) {
|
||||||
|
Loading…
Reference in New Issue
Block a user