External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 14:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use VIR_MASS_CLOSE in LXC container startup

Browse Source 
In the LXC container startup code when switching stdio
streams, we call VIR_FORCE_CLOSE on all FDs. This triggers
a huge number of warnings, but we don't see them because
stdio is closed at this point. strace() however shows them
which can confuse people debugging the code. Switch to
VIR_MASS_CLOSE to avoid this

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-03-07 16:39:33 +00:00
parent a66b32d929
commit 58e0accd8a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lxc/lxc_container.c
View File

@ -245,7 +245,7 @@ static int lxcContainerSetStdio(int control, int ttyfd, int handshakefd)
for (i = 0; i < open_max; i++) for (i = 0; i < open_max; i++)
if (i != ttyfd && i != control && i != handshakefd) { if (i != ttyfd && i != control && i != handshakefd) {
int tmpfd = i; int tmpfd = i;
VIR_FORCE_CLOSE(tmpfd); VIR_MASS_CLOSE(tmpfd);
} }
if (dup2(ttyfd, 0) < 0) { if (dup2(ttyfd, 0) < 0) {