External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-30 01:43:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

nwfilter: Remove Coverity DEADCODE warning

Browse Source 
The nwfilterStateInitialize() would only assign sysbus inside
a WITH_DBUS conditional, thus leaving a subsequent check for sysbus
and nwfilterDriverInstallDBusMatches() as a no-op

Rather than try to add WITH_DBUS conditions which ended up conflicting
with the usage of HAVE_FIREWALLD conditionals, just remove the WITH_DBUS
since virdbus.c has entry points for with and without conditions.
This commit is contained in:
John Ferlan 2013-12-02 14:36:51 -05:00
parent 2e1ced5794
commit 5a298ec040
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nwfilter/nwfilter_driver.c
View File

@ -177,11 +177,9 @@ nwfilterStateInitialize(bool privileged,
if (!privileged) if (!privileged)
return 0; return 0;
#if WITH_DBUS
if (virDBusHasSystemBus() && if (virDBusHasSystemBus() &&
!(sysbus = virDBusGetSystemBus())) !(sysbus = virDBusGetSystemBus()))
return -1; return -1;
#endif /* WITH_DBUS */
if (VIR_ALLOC(driverState) < 0) if (VIR_ALLOC(driverState) < 0)
return -1; return -1;