External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

Avoid compiler warnings about int -> void * casts

Browse Source 
GCC is a little confused about the cast of beginthread/beginthreadex
from unsigned long -> void *. Go via an intermediate variable avoids
the bogus warning, and makes the code a little cleaner

* src/util/threads-win32.c: Avoid compiler warning in cast
This commit is contained in:
Daniel P. Berrange 2011-04-05 15:59:17 +01:00
parent fdcd06ef71
commit 5b099250e3
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/threads-win32.c
View File

@ -262,6 +262,7 @@ int virThreadCreate(virThreadPtr thread,
void *opaque) void *opaque)
{ {
struct virThreadArgs *args; struct virThreadArgs *args;
uintptr_t ret;
if (VIR_ALLOC(args) < 0) if (VIR_ALLOC(args) < 0)
return -1; return -1;
@ -271,17 +272,20 @@ int virThreadCreate(virThreadPtr thread,
thread->joinable = joinable; thread->joinable = joinable;
if (joinable) { if (joinable) {
thread->thread = (HANDLE)_beginthreadex(NULL, 0, ret = _beginthreadex(NULL, 0,
virThreadHelperJoinable, virThreadHelperJoinable,
args, 0, NULL); args, 0, NULL);
if (thread->thread == 0) if (ret == 0)
return -1; return -1;
} else { } else {
thread->thread = (HANDLE)_beginthread(virThreadHelperDaemon, ret = _beginthread(virThreadHelperDaemon,
0, args); 0, args);
if (thread->thread == (HANDLE)-1L) if (ret == -1L)
return -1; return -1;
} }
thread->thread = (HANDLE)ret;
return 0; return 0;
} }