External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu_process: remove unnecessary iothread check

Browse Source 
The situation covered by the removed code will not ever happen.
This code is called only while starting a new QEMU process where
the capabilities where already checked and while attaching to
existing QEMU process where we don't even detect the iothreads.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2017-02-20 18:05:18 +01:00
parent 7e3dd50650
commit 5b37115c3c
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/qemu/qemu_process.c
View File

@ -2101,32 +2101,6 @@ qemuProcessDetectIOThreadPIDs(virQEMUDriverPtr driver,
int ret = -1;
size_t i;
if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_OBJECT_IOTHREAD)) {
/* The following check is because at one time a domain could
* define iothreadids and start the domain - only failing the
* capability check when attempting to add a disk. Because the
* iothreads and [n]iothreadids were left untouched other code
* assumed it could use the ->thread_id value to make thread_id
* based adjustments (e.g. pinning, scheduling) which while
* succeeding would execute on the calling thread.
*/
if (vm->def->niothreadids) {
for (i = 0; i < vm->def->niothreadids; i++) {
/* Check if the domain had defined any iothreadid elements
* and supply a VIR_INFO indicating that it's being removed.
*/
if (!vm->def->iothreadids[i]->autofill)
VIR_INFO("IOThreads not supported, remove iothread id '%u'",
vm->def->iothreadids[i]->iothread_id);
virDomainIOThreadIDDefFree(vm->def->iothreadids[i]);
}
/* Remove any trace */
VIR_FREE(vm->def->iothreadids);
vm->def->niothreadids = 0;
}
return 0;
}
/* Get the list of IOThreads from qemu */
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
goto cleanup;