From 5c953401005c2ffaa48aa394c98e01ad680596f6 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 16 Feb 2022 16:24:01 +0100 Subject: [PATCH] virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The fix was on RPC level so everything should advertise it. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Andrea Bolognani --- src/driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index d070861cfd..bcf5db5998 100644 --- a/src/driver.c +++ b/src/driver.c @@ -357,10 +357,14 @@ virDriverFeatureIsGlobal(virDrvFeature feat, * At this point everything supports them and thus also drivers need to * always advertise this feature */ case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + /* Feature flag exposes that the accidental switching of order of arguments + * in the public API trampoline virNetworkUpdate is known. Updated clients + * thus use the correct ordering with an updated server. All drivers must + * signal support for this feature. */ + case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: *supported = 1; return true; - case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER: case VIR_DRV_FEATURE_FD_PASSING: case VIR_DRV_FEATURE_MIGRATION_V2: case VIR_DRV_FEATURE_MIGRATION_V3: