External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-12 22:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

vbox: Report an error when VBox CAPI initialization fails

Browse Source 
If initialization of VBOX fails inside of _pfnInitialize an
negative value is returned to signal an error condition to a
caller but no error message is printed out. Reporting an error
may shed more light into why VBOX failed to initialize.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Michal Privoznik 2024-10-05 23:50:25 +02:00
parent 10320ad526
commit 5ca7f27f75
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/vbox/vbox_tmpl.c
View File

@ -429,13 +429,18 @@ static int _pfnInitialize(struct _vboxDriver *driver)
{ {
nsresult rc; nsresult rc;
if (!(driver->pFuncs = g_pfnGetFunctions(VBOX_XPCOMC_VERSION))) if (!(driver->pFuncs = g_pfnGetFunctions(VBOX_XPCOMC_VERSION))) {
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
_("Unable to get pointer to VirtualBox vtable"));
return -1; return -1;
}
rc = driver->pFuncs->pfnClientInitialize(IVIRTUALBOXCLIENT_IID_STR, rc = driver->pFuncs->pfnClientInitialize(IVIRTUALBOXCLIENT_IID_STR,
&driver->vboxClient); &driver->vboxClient);
if (NS_FAILED(rc)) { if (NS_FAILED(rc)) {
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
_("Unable to initialize VirtualBox C API client"));
return -1; return -1;
} else { } else {
driver->vboxClient->vtbl->GetVirtualBox(driver->vboxClient, &driver->vboxObj); driver->vboxClient->vtbl->GetVirtualBox(driver->vboxClient, &driver->vboxObj);