From 5dd3b5e32ae7c97e820261ec9e71ebe0ffcf1719 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 23 Sep 2013 14:18:04 +0100 Subject: [PATCH] Fix missing OOM check in qemuParseCommandLine when splitting strings The qemuParseCommandLine method did not check the return value of virStringSplit to see if OOM had occurred. This lead to dereference of a NULL pointer on OOM. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 83597ee785..850cceaa26 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -11387,7 +11387,8 @@ qemuParseCommandLine(virCapsPtr qemuCaps, * Set os.machine only if first parameter lacks '=' or * contains explicit type='...' */ WANT_VALUE(); - list = virStringSplit(val, ",", 0); + if (!(list = virStringSplit(val, ",", 0))) + goto error; param = list[0]; if (STRPREFIX(param, "type="))