External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Need to check return of virGetLastError

Browse Source 
Cannot assume virGetLastError returns non-NULL value - modify the code to
fetch err and check if err && err->code

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2016-07-18 14:25:43 -04:00
parent dfb18b0afb
commit 5ddaa7ef2d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/qemuhelptest.c
View File

@ -60,7 +60,9 @@ static int testHelpStrParsing(const void *data)
if (virQEMUCapsParseHelpStr("QEMU", help, flags, if (virQEMUCapsParseHelpStr("QEMU", help, flags,
&version, &is_kvm, &kvm_version, false, NULL) == -1) { &version, &is_kvm, &kvm_version, false, NULL) == -1) {
if (info->error && virGetLastError()->code == info->error) virErrorPtr err = virGetLastError();
if (info->error && err && err->code == info->error)
ret = 0; ret = 0;
goto cleanup; goto cleanup;
} }