External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only detect PCI Express devices as root in udev nodedev driver

Browse Source 
This stops the error message spam when running unprivileged
libvirtd:
2014-06-30 12:38:47.990+0000: 631: error : virPCIDeviceConfigOpen:300 :
Failed to open config space file
'/sys/bus/pci/devices/0000:00:00.0/config': Permission denied

Reported by Daniel Berrange:
https://www.redhat.com/archives/libvir-list/2014-June/msg01082.html
This commit is contained in:
Ján Tomko 2014-06-30 15:18:23 +02:00
parent 1229ef493f
commit 5de9b50259
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/node_device/node_device_udev.c
View File

@ -429,6 +429,7 @@ static int udevProcessPCI(struct udev_device *device,
virPCIDeviceAddress addr;
virPCIEDeviceInfoPtr pci_express = NULL;
virPCIDevicePtr pciDev = NULL;
udevPrivate *priv = driverState->privateData;
int tmpGroup, ret = -1;
char *p;
int rc;
@ -544,7 +545,8 @@ static int udevProcessPCI(struct udev_device *device,
data->pci_dev.function)))
goto out;
if (virPCIDeviceIsPCIExpress(pciDev) > 0) {
/* We need to be root to read PCI device configs */
if (priv->privileged && virPCIDeviceIsPCIExpress(pciDev) > 0) {
if (VIR_ALLOC(pci_express) < 0)
goto out;