External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

syntax-check: Forbid use of qsort()

Browse Source 
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Michal Privoznik 2023-11-23 10:54:57 +01:00
parent cfcbba4c2b
commit 5dff94115c
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
build-aux/syntax-check.mk
View File

@ -248,6 +248,13 @@ sc_prohibit_canonicalize_file_name:
halt='use virFileCanonicalizePath() instead of canonicalize_file_name()' \ halt='use virFileCanonicalizePath() instead of canonicalize_file_name()' \
$(_sc_search_regexp) $(_sc_search_regexp)
# qsort from glibc has unstable sort ordering for "equal" members
sc_prohibit_qsort:
@prohibit='\<(qsort|qsort_r) *\(' \
exclude='exempt from syntax-check' \
halt='use g_qsort_with_data instead of qsort' \
$(_sc_search_regexp)
# Insist on correct types for [pug]id. # Insist on correct types for [pug]id.
sc_correct_id_types: sc_correct_id_types:
@prohibit='\<(int|long) *[pug]id\>' \ @prohibit='\<(int|long) *[pug]id\>' \

3
tools/nss/libvirt_nss.c
View File

@ -71,7 +71,8 @@ sortAddr(leaseAddress *tmpAddress,
size_t ntmpAddress) size_t ntmpAddress)
{ {
if (tmpAddress) if (tmpAddress)
qsort(tmpAddress, ntmpAddress, sizeof(*tmpAddress), leaseAddressSorter); qsort(tmpAddress, ntmpAddress, /* exempt from syntax-check */
sizeof(*tmpAddress), leaseAddressSorter);
} }