External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

acl: remove various left over Xen ACL whitelist entries

Browse Source 
The legacy xen driver is removed, so these ACL hacks can be removed
too now.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2018-04-12 16:23:44 +01:00
parent 026ae4933c
commit 5e75d3a005
1 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/check-aclrules.pl
View File

@ -63,26 +63,12 @@ my %whitelist = (
"localOnly" => 1,
);
# Temp hack - remove it once xen driver is fixed
# XXX this vzDomainMigrateConfirm3Params looks
# bogus - determine why it doesn't have a valid
# ACL check.
my %implwhitelist = (
"xenUnifiedDomainRestore" => 1,
"xenUnifiedDomainRestoreFlags" => 1,
"xenUnifiedDomainMigratePrepare" => 1,
"xenUnifiedNodeDeviceDettach" => 1,
"xenUnifiedNodeDeviceDetachFlags" => 1,
"xenUnifiedNodeDeviceReset" => 1,
"xenUnifiedDomainIsActive" => 1,
"xenUnifiedDomainIsPersistent" => 1,
"xenUnifiedDomainIsUpdated" => 1,
"xenUnifiedDomainOpenConsole" => 1,
"vzDomainMigrateConfirm3Params" => 1,
);
my %filterimplwhitelist = (
"xenUnifiedConnectListDomains" => 1,
"xenUnifiedConnectNumOfDomains" => 1,
"xenUnifiedConnectListDefinedDomains" => 1,
"xenUnifiedConnectNumOfDefinedDomains" => 1,
);
my $lastfile;
@ -236,8 +222,7 @@ while (<>) {
}
if (exists $filtered{$api} &&
!exists $aclfilters{$impl} &&
!exists $filterimplwhitelist{$impl}) {
!exists $aclfilters{$impl}) {
print "$ARGV:$. Missing ACL filter in function '$impl' for '$api'\n";
$status = 1;
}