External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 20:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

interface: fix udev backend use after free

Browse Source 
udevIfaceListAllInterface() used the udev_device after it had its ref
count decremented which results in a use after free issue.
This commit is contained in:
Doug Goldstein 2013-02-17 22:26:38 -06:00
parent 24cf110e48
commit 5eb621fcb3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/interface/interface_backend_udev.c
View File

@ -359,7 +359,6 @@ udevIfaceListAllInterfaces(virConnectPtr conn,
name = udev_device_get_sysname(dev); name = udev_device_get_sysname(dev);
macaddr = udev_device_get_sysattr_value(dev, "address"); macaddr = udev_device_get_sysattr_value(dev, "address");
status = STREQ(udev_device_get_sysattr_value(dev, "operstate"), "up"); status = STREQ(udev_device_get_sysattr_value(dev, "operstate"), "up");
udev_device_unref(dev);
/* Filter the results */ /* Filter the results */
if (status && (flags & VIR_CONNECT_LIST_INTERFACES_ACTIVE)) if (status && (flags & VIR_CONNECT_LIST_INTERFACES_ACTIVE))
@ -375,6 +374,7 @@ udevIfaceListAllInterfaces(virConnectPtr conn,
} }
count++; count++;
} }
udev_device_unref(dev);
} }
/* Drop our refcounts */ /* Drop our refcounts */