External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-31 05:57:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: Alter virAuthGet*Path API return processing

Browse Source 
If we never find the valid credtype in the list, then we'd return
NULL without an error signaled forcing the caller to generate one
that will probably be incorrect. Let's be specific.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
This commit is contained in:
John Ferlan 2018-08-14 10:11:50 -04:00
parent efd8261541
commit 5f0a9c45b3
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/util/virauth.c
View File

@ -191,10 +191,12 @@ virAuthGetUsernamePath(const char *path,
if ((*(auth->cb))(&cred, 1, auth->cbdata) < 0)
VIR_FREE(cred.result);
break;
return cred.result;
}
return cred.result;
virReportError(VIR_ERR_AUTH_FAILED, "%s",
_("Missing VIR_CRED_AUTHNAME credential type"));
return NULL;
}
@ -267,10 +269,13 @@ virAuthGetPasswordPath(const char *path,
if ((*(auth->cb))(&cred, 1, auth->cbdata) < 0)
VIR_FREE(cred.result);
break;
return cred.result;
}
return cred.result;
virReportError(VIR_ERR_AUTH_FAILED, "%s",
_("Missing VIR_CRED_PASSPHRASE or VIR_CRED_NOECHOPROMPT "
"credential type"));
return NULL;
}