Pass config file object through to driver open methods

The virConnectOpenInternal method opens the libvirt client
config file and uses it to resolve things like URI aliases.

There may be driver specific things that are useful to
store in the config file too, so rather than have them
re-parse the same file, pass the virConfPtr down to the
drivers.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

src/bhyve/bhyve_driver.c

@@ -178,6 +178,7 @@ bhyveDomObjFromDomain(virDomainPtr domain)
 static virDrvOpenStatus
 bhyveConnectOpen(virConnectPtr conn,
                  virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                 virConfPtr conf ATTRIBUTE_UNUSED,
                  unsigned int flags)
 {
      virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);

src/driver-hypervisor.h

@@ -28,6 +28,7 @@
 typedef virDrvOpenStatus
 (*virDrvConnectOpen)(virConnectPtr conn,
                      virConnectAuthPtr auth,
+                     virConfPtr conf,
                      unsigned int flags);
 
 typedef int

src/esx/esx_driver.c

@@ -841,6 +841,7 @@ esxConnectToVCenter(esxPrivate *priv,
  */
 static virDrvOpenStatus
 esxConnectOpen(virConnectPtr conn, virConnectAuthPtr auth,
+               virConfPtr conf ATTRIBUTE_UNUSED,
                unsigned int flags)
 {
     virDrvOpenStatus result = VIR_DRV_OPEN_ERROR;

src/hyperv/hyperv_driver.c

@@ -58,7 +58,9 @@ hypervFreePrivate(hypervPrivate **priv)
 
 
 static virDrvOpenStatus
-hypervConnectOpen(virConnectPtr conn, virConnectAuthPtr auth, unsigned int flags)
+hypervConnectOpen(virConnectPtr conn, virConnectAuthPtr auth,
+                  virConfPtr conf ATTRIBUTE_UNUSED,
+                  unsigned int flags)
 {
     virDrvOpenStatus result = VIR_DRV_OPEN_ERROR;
     char *plus;

src/libvirt.c

@@ -1084,7 +1084,7 @@ virConnectOpenInternal(const char *name,
         ret->secretDriver = virConnectDriverTab[i]->secretDriver;
         ret->storageDriver = virConnectDriverTab[i]->storageDriver;
 
-        res = virConnectDriverTab[i]->hypervisorDriver->connectOpen(ret, auth, flags);
+        res = virConnectDriverTab[i]->hypervisorDriver->connectOpen(ret, auth, conf, flags);
         VIR_DEBUG("driver %zu %s returned %s",
                   i, virConnectDriverTab[i]->hypervisorDriver->name,
                   res == VIR_DRV_OPEN_SUCCESS ? "SUCCESS" :

src/libxl/libxl_driver.c

@@ -763,6 +763,7 @@ libxlStateReload(void)
 static virDrvOpenStatus
 libxlConnectOpen(virConnectPtr conn,
                  virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                 virConfPtr conf ATTRIBUTE_UNUSED,
                  unsigned int flags)
 {
     virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);

src/lxc/lxc_driver.c

@@ -155,6 +155,7 @@ lxcDomObjFromDomain(virDomainPtr domain)
 
 static virDrvOpenStatus lxcConnectOpen(virConnectPtr conn,
                                        virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                                       virConfPtr conf ATTRIBUTE_UNUSED,
                                        unsigned int flags)
 {
     virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);

src/openvz/openvz_driver.c

@@ -1423,6 +1423,7 @@ openvzDomainSetVcpus(virDomainPtr dom, unsigned int nvcpus)
 
 static virDrvOpenStatus openvzConnectOpen(virConnectPtr conn,
                                           virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                                          virConfPtr conf ATTRIBUTE_UNUSED,
                                           unsigned int flags)
 {
     struct openvz_driver *driver;

src/phyp/phyp_driver.c

@@ -1123,7 +1123,9 @@ virDomainDefParserConfig virPhypDriverDomainDefParserConfig = {
 
 static virDrvOpenStatus
 phypConnectOpen(virConnectPtr conn,
-                virConnectAuthPtr auth, unsigned int flags)
+                virConnectAuthPtr auth,
+                virConfPtr conf ATTRIBUTE_UNUSED,
+                unsigned int flags)
 {
     LIBSSH2_SESSION *session = NULL;
     int internal_socket = -1;

src/qemu/qemu_driver.c

@@ -1132,6 +1132,7 @@ qemuStateCleanup(void)
 
 static virDrvOpenStatus qemuConnectOpen(virConnectPtr conn,
                                         virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                                        virConfPtr conf ATTRIBUTE_UNUSED,
                                         unsigned int flags)
 {
     virQEMUDriverConfigPtr cfg = NULL;

src/remote/remote_driver.c

@@ -1180,6 +1180,7 @@ remoteAllocPrivateData(void)
 static virDrvOpenStatus
 remoteConnectOpen(virConnectPtr conn,
                   virConnectAuthPtr auth,
+                  virConfPtr conf ATTRIBUTE_UNUSED,
                   unsigned int flags)
 {
     struct private_data *priv;

src/test/test_driver.c

@@ -1411,6 +1411,7 @@ testConnectAuthenticate(virConnectPtr conn,
 
 static virDrvOpenStatus testConnectOpen(virConnectPtr conn,
                                         virConnectAuthPtr auth,
+                                        virConfPtr conf ATTRIBUTE_UNUSED,
                                         unsigned int flags)
 {
     int ret;

src/uml/uml_driver.c

@@ -1195,6 +1195,7 @@ static void umlShutdownVMDaemon(struct uml_driver *driver,
 
 static virDrvOpenStatus umlConnectOpen(virConnectPtr conn,
                                        virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                                       virConfPtr conf ATTRIBUTE_UNUSED,
                                        unsigned int flags)
 {
     virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);

src/vbox/vbox_common.c

@@ -391,6 +391,7 @@ static void vboxUninitialize(vboxGlobalData *data)
 static virDrvOpenStatus
 vboxConnectOpen(virConnectPtr conn,
                 virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                virConfPtr conf ATTRIBUTE_UNUSED,
                 unsigned int flags)
 {
     vboxGlobalData *data = NULL;

src/vbox/vbox_driver.c

@@ -53,6 +53,7 @@ VIR_LOG_INIT("vbox.vbox_driver");
 #if !defined(WITH_DRIVER_MODULES) || defined(VBOX_DRIVER)
 static virDrvOpenStatus dummyConnectOpen(virConnectPtr conn,
                                          virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                                         virConfPtr conf ATTRIBUTE_UNUSED,
                                          unsigned int flags)
 {
     uid_t uid = geteuid();

src/vmware/vmware_driver.c

@@ -118,6 +118,7 @@ vmwareDomainXMLConfigInit(void)
 static virDrvOpenStatus
 vmwareConnectOpen(virConnectPtr conn,
                   virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+                  virConfPtr conf ATTRIBUTE_UNUSED,
                   unsigned int flags)
 {
     struct vmware_driver *driver;

src/vz/vz_driver.c

@@ -333,6 +333,7 @@ vzDriverObjNew(void)
 static virDrvOpenStatus
 vzConnectOpen(virConnectPtr conn,
               virConnectAuthPtr auth ATTRIBUTE_UNUSED,
+              virConfPtr conf ATTRIBUTE_UNUSED,
               unsigned int flags)
 {
     vzDriverPtr driver = NULL;

src/xen/xen_driver.c

@@ -404,7 +404,9 @@ xenDomainXMLConfInit(void)
 
 
 static virDrvOpenStatus
-xenUnifiedConnectOpen(virConnectPtr conn, virConnectAuthPtr auth, unsigned int flags)
+xenUnifiedConnectOpen(virConnectPtr conn, virConnectAuthPtr auth,
+                      virConfPtr conf ATTRIBUTE_UNUSED,
+                      unsigned int flags)
 {
     xenUnifiedPrivatePtr priv;
 

src/xenapi/xenapi_driver.c

@@ -135,6 +135,7 @@ getCapsObject(void)
  */
 static virDrvOpenStatus
 xenapiConnectOpen(virConnectPtr conn, virConnectAuthPtr auth,
+                  virConfPtr conf ATTRIBUTE_UNUSED,
                   unsigned int flags)
 {
     char *username = NULL;