mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-08 07:15:46 +00:00
vircapstest: Avoid (im)possible strcmp call with NULL argument
Some compilers may get confused and decide we are calling strcmp with NULL argument from test_virCapsDomainDataLookupLXC. Although this does not really happen since the call is guarded with (data->machinetype != expect_machinetype), using STRNEQ_NULLABLE is easier to understand, less fragile, and doing so makes sure strcmp is never called with NULL argument. Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
parent
f9d8b0270f
commit
5f244e3161
@ -188,11 +188,10 @@ doCapsCompare(virCapsPtr caps,
|
|||||||
goto error;
|
goto error;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (data->machinetype != expect_machinetype &&
|
if (STRNEQ_NULLABLE(data->machinetype, expect_machinetype)) {
|
||||||
STRNEQ(data->machinetype, expect_machinetype)) {
|
|
||||||
fprintf(stderr, "data->machinetype=%s doesn't match "
|
fprintf(stderr, "data->machinetype=%s doesn't match "
|
||||||
"expect_machinetype=%s\n",
|
"expect_machinetype=%s\n",
|
||||||
data->machinetype, expect_machinetype);
|
NULLSTR(data->machinetype), NULLSTR(expect_machinetype));
|
||||||
goto error;
|
goto error;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user