External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-25 14:05:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuDomainChangeNet: Forbid changing MTU

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=1447618

Currently, any attempt to change MTU on an interface that is
plugged to a running domain is silently ignored. We should either
do what's asked or error out. Well, we can update the host side
of the interface, but we cannot change 'host_mtu' attribute for
the virtio-net device. Therefore we have to error out.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Laine Stump <laine@laine.org>
This commit is contained in:
Michal Privoznik 2017-06-08 13:45:31 +02:00
parent f00e6f8bc9
commit 5f44d7e357
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_hotplug.c
View File

@ -3138,6 +3138,12 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
/* vlan can be modified, and will be checked later */ /* vlan can be modified, and will be checked later */
/* linkstate can be modified */ /* linkstate can be modified */
if (olddev->mtu != newdev->mtu) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("cannot modify MTU"));
goto cleanup;
}
/* allocate new actual device to compare to old - we will need to /* allocate new actual device to compare to old - we will need to
* free it if we fail for any reason * free it if we fail for any reason
*/ */