External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 19:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

event: ignore attempts to replace the event loop impl

Browse Source 
Although not previously explicitly documented, the expectation for
the libvirt event loop is that an implementation is registered early
in application startup, before calling any libvirt APIs and then
run forever after. Replacing a previously registered event loop is
not safe & subject to races even if virConnectClose has been called
on open handles, due to delayed deregistration of callbacks during
conenction close.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2017-09-01 13:47:04 +01:00
parent 5a1a649dcf
commit 5f5c515bbd
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/util/virevent.c
View File

@ -220,6 +220,13 @@ virEventRemoveTimeout(int timer)
* existing event loop implementation, then the
* virEventRegisterDefaultImpl() method can be used to setup
* the generic libvirt implementation.
*
* Once registered, the event loop implementation cannot be
* changed, and must be run continuously. Note that callbacks
* may remain registered for a short time even after calling
* virConnectClose on all open connections, so it is not safe
* to stop running the event loop immediately after closing
* the connection.
*/
void virEventRegisterImpl(virEventAddHandleFunc addHandle,
virEventUpdateHandleFunc updateHandle,
@ -233,6 +240,12 @@ void virEventRegisterImpl(virEventAddHandleFunc addHandle,
addHandle, updateHandle, removeHandle,
addTimeout, updateTimeout, removeTimeout);
if (addHandleImpl || updateHandleImpl || removeHandleImpl ||
addTimeoutImpl || updateTimeoutImpl || removeHandleImpl) {
VIR_WARN("Ignoring attempt to replace registered event loop");
return;
}
addHandleImpl = addHandle;
updateHandleImpl = updateHandle;
removeHandleImpl = removeHandle;