External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

qemuSharedDeviceEntryRemove: Free domain name before VIR_DELETE_ELEMENT

Browse Source 
The macro VIR_DELETE_ELEMENT assume that the items being deleted
have already been cleared, so we must explicitly free domain name
from the list of domains using the shared device to prevent a
memory leak.

Signed-off-by: Xu Yandong <xuyandong2@huawei.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Xu Yandong 2019-09-19 04:02:07 -04:00 committed by Michal Privoznik
parent 89d724b157
commit 5f646ffda0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_conf.c
View File

@ -1620,10 +1620,12 @@ qemuSharedDeviceEntryRemove(virQEMUDriverPtr driver,
if (!qemuSharedDeviceEntryDomainExists(entry, name, &idx)) if (!qemuSharedDeviceEntryDomainExists(entry, name, &idx))
return 0; return 0;
if (entry->ref != 1) if (entry->ref != 1) {
VIR_FREE(entry->domains[idx]);
VIR_DELETE_ELEMENT(entry->domains, idx, entry->ref); VIR_DELETE_ELEMENT(entry->domains, idx, entry->ref);
else } else {
ignore_value(virHashRemoveEntry(driver->sharedDevices, key)); ignore_value(virHashRemoveEntry(driver->sharedDevices, key));
}
return 0; return 0;
} }