External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

nodedev: mdev: Report an error when mdev path resolution fails

Browse Source 
It might happen that virFileResolveLinkHelper fails on the lstat system
call. virFileResolveLink expects the caller to report an error when it
fails, however this wasn't the case for udevProcessMediatedDevice.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Erik Skultety 2017-06-20 16:50:26 +02:00
parent 03fb4e3dea
commit 6167d8494c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/node_device/node_device_udev.c
View File

@ -1121,8 +1121,10 @@ udevProcessMediatedDevice(struct udev_device *dev,
if (virAsprintf(&linkpath, "%s/mdev_type", udev_device_get_syspath(dev)) < 0)
goto cleanup;
if (virFileResolveLink(linkpath, &canonicalpath) < 0)
if (virFileResolveLink(linkpath, &canonicalpath) < 0) {
virReportSystemError(errno, _("failed to resolve '%s'"), linkpath);
goto cleanup;
}
if (VIR_STRDUP(data->type, last_component(canonicalpath)) < 0)
goto cleanup;