mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 14:15:28 +00:00
security driver: ignore EINVAL when chowning an image file
This fixes: https://bugzilla.redhat.com/show_bug.cgi?id=702044 https://bugzilla.redhat.com/show_bug.cgi?id=709454 Both of these complain of a failure to use an image file that resides on a read-only NFS volume. The function in the DAC security driver that chowns image files to the qemu user:group before using them already has special cases to ignore failure of chown on read-only file systems, and in a few other cases, but it hadn't been checking for EINVAL, which is what is returned if the qemu user doesn't even exist on the NFS server. Since the explanation of EINVAL in the chown man page almost exactly matches the log message already present for the case of EOPNOTSUPP, I've just added EINVAL to that same conditional.
This commit is contained in:
parent
6b5c589d84
commit
62ed801c13
@ -110,7 +110,7 @@ virSecurityDACSetOwnership(const char *path, int uid, int gid)
|
||||
}
|
||||
}
|
||||
|
||||
if (chown_errno == EOPNOTSUPP) {
|
||||
if (chown_errno == EOPNOTSUPP || chown_errno == EINVAL) {
|
||||
VIR_INFO("Setting user and group to '%d:%d' on '%s' not supported by filesystem",
|
||||
uid, gid, path);
|
||||
} else if (chown_errno == EPERM) {
|
||||
|
Loading…
Reference in New Issue
Block a user