External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-08-26 10:31:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed memory corruption after destroying network/domain objects in QEMU driver

Browse Source
This commit is contained in:
Daniel P. Berrange 2007-07-06 21:52:42 +00:00
parent f1f70e5099
commit 62efeb0752
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
Fri Jul 6 17:50:00 EST 2007 Daniel P.Berrange <berrange@redhat.com>
* src/qemu_driver.c: Use virFreeDomain and virFreeNetwork
instead of free(), to ensure the objects are removed from
the cache
Fri Jul 6 16:19:00 BST 2007 Richard W.M. Jones <rjones@redhat.com> Fri Jul 6 16:19:00 BST 2007 Richard W.M. Jones <rjones@redhat.com>
* src/libvirt.c, src/qemu_driver.c: If the virNetworkLookup* * src/libvirt.c, src/qemu_driver.c: If the virNetworkLookup*

9
src/qemu_driver.c
View File

@ -1903,7 +1903,7 @@ static int qemudDomainDestroy(virDomainPtr dom) {
} }
ret = qemudShutdownVMDaemon(driver, vm); ret = qemudShutdownVMDaemon(driver, vm);
free(dom); virFreeDomain(dom->conn, dom);
return ret; return ret;
} }
@ -2332,6 +2332,7 @@ static int qemudNetworkStart(virNetworkPtr net) {
static int qemudNetworkDestroy(virNetworkPtr net) { static int qemudNetworkDestroy(virNetworkPtr net) {
struct qemud_driver *driver = (struct qemud_driver *)net->conn->networkPrivateData; struct qemud_driver *driver = (struct qemud_driver *)net->conn->networkPrivateData;
struct qemud_network *network = qemudFindNetworkByUUID(driver, net->uuid); struct qemud_network *network = qemudFindNetworkByUUID(driver, net->uuid);
int ret;
if (!network) { if (!network) {
qemudReportError(net->conn, NULL, net, VIR_ERR_INVALID_NETWORK, qemudReportError(net->conn, NULL, net, VIR_ERR_INVALID_NETWORK,
@ -2339,7 +2340,11 @@ static int qemudNetworkDestroy(virNetworkPtr net) {
return -1; return -1;
} }
return qemudShutdownNetworkDaemon(driver, network); ret = qemudShutdownNetworkDaemon(driver, network);
virFreeNetwork(net->conn, net);
return ret;
} }
static char *qemudNetworkDumpXML(virNetworkPtr net, int flags ATTRIBUTE_UNUSED) { static char *qemudNetworkDumpXML(virNetworkPtr net, int flags ATTRIBUTE_UNUSED) {