mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-27 19:11:16 +00:00
conf: Fix possible memleak in capabilities
If formatting NUMA topology fails, the function returns immediatelly, but the buffer structure allocated on the stack references lot of heap-allocated memory and that would get lost in such case. Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
parent
ae102b5d7b
commit
6369ee0483
@ -955,7 +955,7 @@ virCapabilitiesFormatXML(virCapsPtr caps)
|
||||
if (caps->host.nnumaCell &&
|
||||
virCapabilitiesFormatNUMATopology(&buf, caps->host.nnumaCell,
|
||||
caps->host.numaCell) < 0)
|
||||
return NULL;
|
||||
goto error;
|
||||
|
||||
for (i = 0; i < caps->host.nsecModels; i++) {
|
||||
virBufferAddLit(&buf, "<secmodel>\n");
|
||||
@ -1072,6 +1072,10 @@ virCapabilitiesFormatXML(virCapsPtr caps)
|
||||
return NULL;
|
||||
|
||||
return virBufferContentAndReset(&buf);
|
||||
|
||||
error:
|
||||
virBufferFreeAndReset(&buf);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/* get the maximum ID of cpus in the host */
|
||||
|
Loading…
Reference in New Issue
Block a user