From 637a1124ae35a51e39c87f0e851b1e8112cb5e26 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 11 Sep 2012 14:44:40 +0100 Subject: [PATCH] Add missing 'goto error' in QEMU command line building If reporting case of a binary not supporting KVM or kQEMU, libvirt forgot to jump to the error branch for cleanup --- src/qemu/qemu_command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b8c5658f5a..a512e6adab 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4449,6 +4449,7 @@ qemuBuildCommandLine(virConnectPtr conn, virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("the QEMU binary %s does not support kqemu"), emulator); + goto error; } break; @@ -4462,6 +4463,7 @@ qemuBuildCommandLine(virConnectPtr conn, virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("the QEMU binary %s does not support kvm"), emulator); + goto error; } break;