External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-13 07:01:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

remote: add mutex when freeing private callbacks

Browse Source 
This commit resolves illegal memory accesses observed via:

  remoteClientFreePrivateCallbacks()
  remoteClientCloseFunc()
  virNetServerClientCloseLocked()
  virNetServerProcessClients()
  daemonServerProcessClients()
  virHashForEach()
  virNetDaemonRun()
  main()

Signed-off-by: Mike Pontillo <mpontillo@digitalocean.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Mike Pontillo 2023-03-07 17:57:56 +00:00 committed by Martin Kletzander
parent c0e60063c9
commit 6386dd897d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/remote/remote_daemon_dispatch.c
View File

@ -1709,6 +1709,8 @@ static void
remoteClientFreePrivateCallbacks(struct daemonClientPrivate *priv) remoteClientFreePrivateCallbacks(struct daemonClientPrivate *priv)
{ {
g_autoptr(virIdentity) sysident = virIdentityGetSystem(); g_autoptr(virIdentity) sysident = virIdentityGetSystem();
VIR_LOCK_GUARD lock = virLockGuardLock(&priv->lock);
virIdentitySetCurrent(sysident); virIdentitySetCurrent(sysident);
DEREG_CB(priv->conn, priv->domainEventCallbacks, DEREG_CB(priv->conn, priv->domainEventCallbacks,