From 642c2312680b8eda867ce22d9e148a17cb07f8f6 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 29 Jul 2019 14:12:22 +0200 Subject: [PATCH] qemumonitorjsontest: Don't leak 'query-jobs' info The returned array of qemuMonitorJobInfo structs must be freed. 164 (16 direct, 148 indirect) bytes in 1 blocks are definitely lost in loss record 64 of 84 at 0x4A3568B: realloc (vg_replace_malloc.c:826) by 0x4D888BD: virReallocN (viralloc.c:244) by 0x4D889B3: virExpandN (viralloc.c:293) by 0x4D88C87: virInsertElementsN (viralloc.c:435) by 0x214004: qemuMonitorJSONGetJobInfo (qemu_monitor_json.c:9185) by 0x148B3F: testQueryJobs (qemumonitorjsontest.c:2979) by 0x14C192: virTestRun (testutils.c:174) by 0x14BF36: mymain (qemumonitorjsontest.c:3286) by 0x14E256: virTestMain (testutils.c:1096) by 0x14BFD9: main (qemumonitorjsontest.c:3298) Signed-off-by: Michal Privoznik ACKed-by: Peter Krempa --- tests/qemumonitorjsontest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index bf89f49aca..522ff5a3d5 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2996,6 +2996,9 @@ testQueryJobs(const void *opaque) ret = 0; cleanup: + for (i = 0; i < njobs; i++) + qemuMonitorJobInfoFree(jobs[i]); + VIR_FREE(jobs); qemuMonitorTestFree(test); return ret; }