External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-26 06:25:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuMonitorJSONBlockdevAdd: Refactor cleanup

Browse Source 
Use automatic variable freeing and get rid of the cleanup section.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
Peter Krempa 2020-02-06 13:03:07 +01:00
parent 37f01262ee
commit 643294110c
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/qemu/qemu_monitor_json.c
View File

@ -8823,25 +8823,19 @@ int
qemuMonitorJSONBlockdevAdd(qemuMonitorPtr mon, qemuMonitorJSONBlockdevAdd(qemuMonitorPtr mon,
virJSONValuePtr props) virJSONValuePtr props)
{ {
virJSONValuePtr cmd; g_autoptr(virJSONValue) cmd = NULL;
virJSONValuePtr reply = NULL; g_autoptr(virJSONValue) reply = NULL;
int ret = -1;
if (!(cmd = qemuMonitorJSONMakeCommandInternal("blockdev-add", props))) if (!(cmd = qemuMonitorJSONMakeCommandInternal("blockdev-add", props)))
return -1; return -1;
if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0)
goto cleanup; return -1;
if (qemuMonitorJSONCheckError(cmd, reply) < 0) if (qemuMonitorJSONCheckError(cmd, reply) < 0)
goto cleanup; return -1;
ret = 0; return 0;
cleanup:
virJSONValueFree(cmd);
virJSONValueFree(reply);
return ret;
} }