External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

virPidFileConstructPath: Drop useless VIR_FREE()

Browse Source 
If a virAsprintf() within the function fails, we call VIR_FREE()
over @rundir variable and jump onto cleanup label, where it is
freed again.  It doesn't hurt, but not make much sense too.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2015-04-15 15:01:02 +02:00
parent 7961713410
commit 6515f3df94
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/util/virpidfile.c
View File

@ -556,11 +556,8 @@ virPidFileConstructPath(bool privileged,
goto cleanup;
}
if (virAsprintf(pidfile, "%s/%s.pid", rundir, progname) < 0) {
VIR_FREE(rundir);
if (virAsprintf(pidfile, "%s/%s.pid", rundir, progname) < 0)
goto cleanup;
}
}
ret = 0;