External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ref-counting for Xen driver event registration

Browse Source
This commit is contained in:
John Levon 2009-01-15 01:18:37 +00:00
parent d6511cf6de
commit 65316d7940
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
Thu Jan 15 01:16:05 GMT 2009 John Levon <levon@movementarian.org>
* src/xen_unified.c: Fix ref-counting for Xen driver event
registration
Wed Jan 14 17:30:54 GMT 2009 John Levon <levon@movementarian.org> Wed Jan 14 17:30:54 GMT 2009 John Levon <levon@movementarian.org>
* docs/devhelp/Makefile.am: Fix devhelp build dependencies * docs/devhelp/Makefile.am: Fix devhelp build dependencies

18
src/xen_unified.c
View File

@ -1359,15 +1359,21 @@ xenUnifiedDomainEventRegister (virConnectPtr conn,
void *opaque, void *opaque,
void (*freefunc)(void *)) void (*freefunc)(void *))
{ {
int ret;
GET_PRIVATE (conn); GET_PRIVATE (conn);
if (priv->xsWatch == -1) { if (priv->xsWatch == -1) {
xenUnifiedError (conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); xenUnifiedError (conn, VIR_ERR_NO_SUPPORT, __FUNCTION__);
return -1; return -1;
} }
conn->refs++; ret = virDomainEventCallbackListAdd(conn, priv->domainEventCallbacks,
return virDomainEventCallbackListAdd(conn, priv->domainEventCallbacks, callback, opaque, freefunc);
callback, opaque, freefunc);
if (ret == 0)
conn->refs++;
return (ret);
} }
static int static int
@ -1382,8 +1388,10 @@ xenUnifiedDomainEventDeregister (virConnectPtr conn,
} }
ret = virDomainEventCallbackListRemove(conn, priv->domainEventCallbacks, ret = virDomainEventCallbackListRemove(conn, priv->domainEventCallbacks,
callback); callback);
virUnrefConnect(conn);
if (ret == 0)
virUnrefConnect(conn);
return ret; return ret;
} }