From 67757b066c3bc347d50ffcb3761a4b88aa773a7f Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Tue, 27 Mar 2018 11:53:41 -0400 Subject: [PATCH] qemu: Fix qemuProcessAutoDestroy Upon entry from virCloseCallbacksRun, the @dom will have a Ref and Lock from virDomainObjListFindByUUIDRef, so there's no need to take an extra reference nor should the code call virDomainObjEndAPI when done since that both Unref's and Unlock's the @dom which means the callers call to EndAPI would be unlocking an unlocked object. At least the Ref saved the code from referencing something already freed. Signed-off-by: John Ferlan Reviewed-by: Marc Hartmayer --- src/qemu/qemu_process.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c0105c8b84..0e7965fc08 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7058,8 +7058,6 @@ qemuProcessAutoDestroy(virDomainObjPtr dom, VIR_DEBUG("vm=%s, conn=%p", dom->def->name, conn); - virObjectRef(dom); - if (priv->job.asyncJob == QEMU_ASYNC_JOB_MIGRATION_IN) stopFlags |= VIR_QEMU_PROCESS_STOP_MIGRATED; @@ -7089,7 +7087,6 @@ qemuProcessAutoDestroy(virDomainObjPtr dom, qemuDomainEventQueue(driver, event); cleanup: - virDomainObjEndAPI(&dom); return dom; }