External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-06 21:15:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Report error when parsing character device target type

Browse Source 
No useful error was being reported when an invalid character device
target type is specified in the domainXML. E.g.

    ...
    <console type="pty">
      <source path="/dev/pts/2"/>
      <target type="kvm" port="0"/>
    </console>
    ...

resulted in

error: Failed to define domain from x.xml
error: An error occurred, but the cause is unknown

With this small patch, the error is more helpful

error: Failed to define domain from x.xml
error: XML error: unknown target type 'kvm' specified for character device
(cherry picked from commit 10a87145f7)
This commit is contained in:
Jim Fehlig 2012-05-09 11:12:38 -06:00 committed by Cole Robinson
parent 4f1b3e4243
commit 6884836d95
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/domain_conf.c
View File

@ -4857,6 +4857,9 @@ virDomainChrDefParseTargetXML(virCapsPtr caps,
if ((def->targetType = if ((def->targetType =
virDomainChrTargetTypeFromString(caps, vmdef, virDomainChrTargetTypeFromString(caps, vmdef,
def->deviceType, targetType)) < 0) { def->deviceType, targetType)) < 0) {
virDomainReportError(VIR_ERR_XML_ERROR,
_("unknown target type '%s' specified for character device"),
targetType);
goto error; goto error;
} }