External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 19:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: fix uninitialized variable in cmdSnapshotEdit

Browse Source 
If the domain can't be looked up, name is used unitialized after the
cleanup label.

Found by coverity.
This commit is contained in:
Ján Tomko 2012-11-15 11:37:32 +01:00 committed by Michal Privoznik
parent 0c996c10e4
commit 689b64d666
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/virsh-snapshot.c
View File

@ -459,7 +459,7 @@ cmdSnapshotEdit(vshControl *ctl, const vshCmd *cmd)
virDomainPtr dom = NULL; virDomainPtr dom = NULL;
virDomainSnapshotPtr snapshot = NULL; virDomainSnapshotPtr snapshot = NULL;
virDomainSnapshotPtr edited = NULL; virDomainSnapshotPtr edited = NULL;
const char *name; const char *name = NULL;
const char *edited_name; const char *edited_name;
bool ret = false; bool ret = false;
unsigned int getxml_flags = VIR_DOMAIN_XML_SECURE; unsigned int getxml_flags = VIR_DOMAIN_XML_SECURE;
@ -532,7 +532,7 @@ cmdSnapshotEdit(vshControl *ctl, const vshCmd *cmd)
ret = true; ret = true;
cleanup: cleanup:
if (!ret) if (!ret && name)
vshError(ctl, _("Failed to update %s"), name); vshError(ctl, _("Failed to update %s"), name);
if (edited) if (edited)
virDomainSnapshotFree(edited); virDomainSnapshotFree(edited);