From 6997b1920f29d3efbccd1cce3169a1bfdc5978f0 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 30 Jan 2008 19:53:10 +0000 Subject: [PATCH] src/libvirt.c (do_open): Avoid double-free upon failure. --- ChangeLog | 2 ++ src/libvirt.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8b26a4b8da..41629f032d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ Wed Jan 30 20:49:34 CET 2008 Jim Meyering + * src/libvirt.c (do_open): Avoid double-free upon failure. + Avoid segfault upon malloc failure, and plug a leak. * src/test.c (testDomainSave): Detect testDomainDumpXML failure. Free "xml". diff --git a/src/libvirt.c b/src/libvirt.c index defadc19ef..c19565fd4e 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -615,7 +615,6 @@ do_open (const char *name, return ret; failed: - free (ret->name); if (ret->driver) ret->driver->close (ret); if (uri) xmlFreeURI(uri); virUnrefConnect(ret);