External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

util: Avoid possible error in virCommandMassClose

Browse Source 
Avoid the chance that sysconf(_SC_OPEN_MAX) returns -1 and thus
would cause virBitmapNew would attempt to allocate a very large
bitmap.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
ACKed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
John Ferlan 2019-07-23 08:12:48 -04:00
parent 73717ca074
commit 6ae4f4a4ce
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/util/vircommand.c
View File

@ -487,6 +487,11 @@ virCommandMassClose(virCommandPtr cmd,
* Therefore we can safely allocate memory here (and transitively call * Therefore we can safely allocate memory here (and transitively call
* opendir/readdir) without a deadlock. */ * opendir/readdir) without a deadlock. */
if (openmax < 0) {
virReportSystemError(errno, "%s", _("sysconf(_SC_OPEN_MAX) failed"));
return -1;
}
if (!(fds = virBitmapNew(openmax))) if (!(fds = virBitmapNew(openmax)))
return -1; return -1;