From 6af5a06275dedd3b438f3e1f20cb4a5b8bea15e1 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Tue, 18 Dec 2012 23:32:01 +0100 Subject: [PATCH] cpu: Make comparing PowerPC CPUs easier to read Revert the condition to make it easier to read. The function is also renamed as ppcCompare to match other functions in PowerPC CPU driver. --- src/cpu/cpu_powerpc.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c index 5e1a7b9c92..ea4f9caa1e 100644 --- a/src/cpu/cpu_powerpc.c +++ b/src/cpu/cpu_powerpc.c @@ -414,15 +414,14 @@ no_memory: } static virCPUCompareResult -PowerPCCompare(virCPUDefPtr host, +ppcCompare(virCPUDefPtr host, virCPUDefPtr cpu) { - if ((cpu->arch != VIR_ARCH_NONE && - (host->arch != cpu->arch)) || - STRNEQ(host->model, cpu->model)) - return VIR_CPU_COMPARE_INCOMPATIBLE; + if ((cpu->arch == VIR_ARCH_NONE || host->arch == cpu->arch) && + STREQ(host->model, cpu->model)) + return VIR_CPU_COMPARE_IDENTICAL; - return VIR_CPU_COMPARE_IDENTICAL; + return VIR_CPU_COMPARE_INCOMPATIBLE; } static int @@ -631,7 +630,7 @@ struct cpuArchDriver cpuDriverPowerPC = { .name = "ppc64", .arch = archs, .narch = ARRAY_CARDINALITY(archs), - .compare = PowerPCCompare, + .compare = ppcCompare, .decode = PowerPCDecode, .encode = NULL, .free = PowerPCDataFree,